Improve Battery health derived efficiency estimations and Fix error divided by zero #3593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for teslamate ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Thanks for your work and the change!
lgtm, beside my comment here #3593 (comment)
|
Does this fix #3582 as well? |
Yes, it does. |
jheredianet
deleted the
BatteryHealth_improve_estimations_by_DerivedEfficiency
branch
|
Hi @JakobLichterfeld since this PR is merged, this other PR (#3582) is not necessary, it should be closed. Thank you. |
JakobLichterfeld
pushed a commit
that referenced
this pull request
Feb 9, 2024
…ivided by zero (#3593) * Improve Battery health derived efficiency estimations and Fix error divided by zero * Fix unit convert * Update screenshot * Keep iteration value * Remove name mention.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an improve on Battery Health estimations, based on derivate efficiency discussed here #3486 (comment)
In the other hand, it fixes the error "divided by zero" on some situations when there is not enough data on charges to do the math, pointed here jheredianet/Teslamate-CustomGrafanaDashboards#62
There are other improvements on XY chart to have a better look