Fix race condition in ErrProtocolNotSupported #138
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a race condition that caused the library (and http proxy) to not recognize ErrProtocolNotSupported, which indicates the vehicle does not support the newer protocol.
The race condition was caused by code that attempted to handshake with multiple vehicle subsystems (domains) in parallel. If one subsystem returned ErrProtocolNotSupported, the pending requests to other subsystems were canceled. In some cases, the context cancellation error would be propagated to the down the stack instead of ErrProtocolNotSupported.
With this fix, the library prioritizes non-context cancellation errors.
Description
Please include a summary of the changes and the related issue.
Type of change
Please select all options that apply to this change:
Checklist:
Confirm you have completed the following steps: