Add timeout options #207
Merged
Add timeout options #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 7, 2024 18:00
The client discards handshake response messages that take too long to receive because a long delay prevents accurate synchronization between the client and vehicle clocks. However, the client still considered the handshake complete after receiving a delayed response. Vehicles send unsolicited handshake response messages when they detect a desychronization, and so the StartSession method relied on this automatic detection without verifying the result. This commit fixes the issue by having the client check that a session was successfully established and retrying as needed.
aaronpkahn
reviewed
Mar 8, 2024
| } | ||
| select { | ||
| case <-time.After(d.conn.RetryInterval()): | ||
| case <-ctx.Done(): |
There was a problem hiding this comment.
thank you for not doing a sleep
aaronpkahn
reviewed
Mar 8, 2024
| case d.outbox <- responseBytes: | ||
| return | ||
| default: | ||
| panic(errOutboxFull) |
There was a problem hiding this comment.
should we accept the test context and t.Fatal instead of panic?
There was a problem hiding this comment.
(1) Can't call t.Fatal from a goroutine (https://pkg.go.dev/testing#B.FailNow); (2) This is called by a stubbed interface implementation, so t can't be passed in the method call, and storing t in structs is, if I recall correctly, Not Recommended.
Both of these issues could be addressed by adding in some plumbing and sending fatal errors through channels, but this doesn't seem worthwhile.
aaronpkahn
approved these changes
Mar 8, 2024
added 2 commits
March 8, 2024 10:14
Timeouts were previously hard-coded. This change allows clients to specify timeouts dynamically.
Adds timeout command-line options that override the defaults.
sethterashima
force-pushed
the
add-timeout-options
branch
from
de089b5 to
dd3584d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where a handshake would incorrectly be marked as completed if the response came in after the timeout expired.
Adds API and CLI options for adjusting timeouts.
Fixes #194
Type of change
Please select all options that apply to this change:
Checklist:
Confirm you have completed the following steps: