Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add event filters to event log table #207

Merged
merged 9 commits into from
Jul 29, 2020
Merged

Conversation

delca85
Copy link
Member

@delca85 delca85 commented Jun 19, 2020

What:

According to #171, the events list is now filtered by events name and type.

Why:

It would be useful to filter events.

How:

  1. create a component to render the list with all of the headers
  2. add react-select as dependency
  3. implement filter mechanism
  • create a component to render the list with all of the headers
  • add react-select as dependency
  • implement filter mechanism

Checklist:

  • Tests
  • Ready to be merged

@smeijer
Copy link
Member

smeijer commented Jun 28, 2020

Hi @delca85!

Thanks for your work on this one. Unfortunately, the branch has run out of sync with develop.

Do you think you can fix the conflicts so we can get this merged?

@delca85
Copy link
Member Author

delca85 commented Jun 28, 2020

Hi @delca85!

Thanks for your work on this one. Unfortunately, the branch has run out of sync with develop.

Do you think you can fix the conflicts so we can get this merged?

@smeijer for sure! I am going to try to fix conflict and push the pr again.

@delca85
Copy link
Member Author

delca85 commented Jun 28, 2020

I think I have fixed all the conflicts without losing any features.
I have made a small enhancement memoizing (through useMemo) itemCount and itemData passed from DomEventsTable to StickyList.

@smeijer smeijer changed the title Feature/filter events feat: add event filters to event log table Jul 1, 2020
@delca85
Copy link
Member Author

delca85 commented Jul 4, 2020

Hey @smeijer, I noticed there were some conflicts again so I solved them.
Please tell me if there is something else I should do to make this pr merged! :)

@smeijer
Copy link
Member

smeijer commented Jul 4, 2020

Hi @delca85!

Thanks, I'm going to check the current version of develop one more time for blocking issues, and then update both testing-playground.com as well as the chrome extension.

After that, this PR is first on my list. So I expect to merge it in a couple of days.

Some help with testing https://develop.testing-playground.com/ for weird things would be awesome though 😇

@delca85
Copy link
Member Author

delca85 commented Jul 4, 2020

Some help with testing https://develop.testing-playground.com/ for weird things would be awesome though 😇

For sure I am going to test it! 👍

@delca85
Copy link
Member Author

delca85 commented Jul 5, 2020

Hey @smeijer where could I write to you some unexpected (at least by me) behavior I found in https://develop.testing-playground.com/ ?

@smeijer
Copy link
Member

smeijer commented Jul 5, 2020

Create an issue? 😇 Just mention there it only occurs on develop. Maybe we should also add a beta label for those kind of tickets?

@smeijer smeijer merged commit 6c47c12 into develop Jul 29, 2020
@smeijer smeijer deleted the feature/filter-events branch July 29, 2020 15:01
smeijer added a commit that referenced this pull request Aug 3, 2020
smeijer added a commit that referenced this pull request Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants