Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: separate pages from components #312

Merged

Conversation

aganglada
Copy link
Collaborator

What:
This PR closes #303 where we want to improve slightly the folder structure, moving pages out of components an App to the root of the project.

Why:

Future maintainability

Checklist:

  • Tests N/A
  • Ready to be merged

@aganglada aganglada requested a review from smeijer December 6, 2020 17:09
@aganglada aganglada self-assigned this Dec 6, 2020
@aganglada aganglada changed the title Moved App outside and pages in its own folder Improve folder structure Dec 6, 2020
@aganglada aganglada requested a review from delca85 December 6, 2020 17:10
@smeijer
Copy link
Member

smeijer commented Dec 8, 2020

@aganglada, thanks! Can you resolve the conflicts?

…da/testing-playground into feature/improve-folder-structure
@aganglada
Copy link
Collaborator Author

@aganglada, thanks! Can you resolve the conflicts?

Done! 😃

@smeijer smeijer changed the title Improve folder structure chore: separate pages from components Dec 9, 2020
@smeijer smeijer merged commit d710dad into testing-library:develop Dec 9, 2020
@smeijer
Copy link
Member

smeijer commented Dec 9, 2020

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve folder structure
2 participants