Add VSCode Extension to header #332
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging this PR means that I must provide support for it, and prevent it from breaking. I'm happy to do that, but I'd suggest that we then merge the extension into this repo first. (like you've suggested before). What do you think? |
|
Make sense, I will prepare another PR. |
|
Hey @smeijer, don't you think we should work on the monorepo structure before merging the extension, the extension is written in TS and maybe it will be confusing to see TS and JS dependencies all together on the same package.json. |
|
Makes sense. What do you propose? Can you contribute to improving the structure? |
Sure, I will have a look at it. |
|
Closing this until we tackle this #34 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Added VSCode Extension link to the Header
Why:
For VSCode Extension visibility
Checklist: