Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we do this, we'll need to update our PyPI first. To test, do the following inside Docker in the
texastribune
repository:pip install -e git://github.com/texastribune/django-locking@cross-tab#egg=locking
Then, test every locking scenario you can think of (fun, right?). At any point, you can put the following in your browser console to see the value(s) stored in local storage:
console.log(JSON.parse(localStorage.getItem('djangoLocking')));
When you're on a story form, it should show something like
{17047: true}
. When you're not, it should be an empty{}
indicating thelock_pk
is no longer in local storage.Scenarios to test include:
console.log()
mentioned above. Confirm it shows an empty value.And anything else that sounds relevant. TBH, I'd love never to deploy this because I'm sure there's some weird polling + read-only + override-something-or-other scenario I'm forgetting about. But hey, it's something.