Fix audit problems by removing lodash #153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphendyr
commented
Dec 10, 2024
| @@ -5,6 +5,7 @@ module.exports = { | |||
| alias: { | |||
| 'my-absolute-test-lib': path.join(__dirname, 'lib/a'), | |||
| 'same-folder-lib': path.resolve(__dirname, 'lib/b'), | |||
| } | |||
| }, | |||
| extensions: ['', '.js'] | |||
There was a problem hiding this comment.
This was my best effort to ensure the extensionsConf code path is tested. However, it's possible I broke some other relevant testing.
raphendyr
commented
Dec 10, 2024
| @@ -42,7 +42,7 @@ module.exports = (args) => { | |||
| mocks: [] | |||
| } | |||
| }, | |||
| exit({node}, {file}) { | |||
| exit({node}) { | |||
|
@theKashey Hi, Sorry to ping you. I, and probably many others, would love if you could spare few moments in this PR. This should help to keep the project in low maintenance mode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project doesn't really use lodash for anything beneficial. This PR removes lodash.
The
somefunction is replaces withforandfind.The
templateis just removed as it's use is not documented and it didn't make sense to me. It could be potential security issue too (depending how the library user manages to config path parameter). Any case, it's not documented, so template rendering is a surprise to the user.In addition, this is a lodash template format, i.e.,
/path/to/<%= ENV_VAR %>.js. At least for me, that is very strange template format for paths. I would assume shell like syntax.The question is, does this result in a major version update or is the minor or patch enough. It's undocumented feature after all.