Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend PILEngine to allow other filters to work #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Muffinman
Copy link

Sorry Github auto-closed #19 when I renamed my branch to match yours.

Re-opening a new PR.

Fixes #12

@fdintino
Copy link
Member

fdintino commented Jul 3, 2024

Sorry for the delayed response, I've been out on paternity leave.

I haven't had a chance to investigate, but in theory this shouldn't be necessary. The fact that it doesn't extend PILEngine is intentional; the __getattr__ method on this class is meant to dispatch to either the image engine or the video engine, depending on the circumstances. The PILEngine methods operate on an underlying static image, so its methods aren't applicable to videos, which are manipulated with calls to execute ffmpeg. In order to fully get these filters to work with the video engine, you would need to map the functionality to the corresponding ffmpeg command line arguments as methods on thumbor_video_engine.engines.video.Engine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems with thumbor.filters.fill
2 participants