Don 918 update homepage #1376
Merged
Don 918 update homepage #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdsl
force-pushed
the
DON-918-update-homepage
branch
from
0a18941 to
e4d8ac4
Compare
…me page testing with query string So to see what the home page would be in 2020 with current code go to e.g. http://localhost:4200/?simulatedDate=2020-01-01 or https://donate-staging.thebiggivetest.org.uk?simulatedDate=2020-01-01
bdsl
force-pushed
the
DON-918-update-homepage
branch
from
90b98eb to
a930331
Compare
bdsl
force-pushed
the
DON-918-update-homepage
branch
from
308042d to
f8af637
Compare
NoelLH
reviewed
Nov 7, 2023
| appearAt: 'asap', | ||
| disappearAt: GMFApplicationCloseDate, | ||
| headerText: "Applications for Green Match Fund are now open!", | ||
| bodyText: "Apply by January 16 2024", |
There was a problem hiding this comment.
Should we standardise on a date format for these? Some copy has the number with suffix followed by the month
There was a problem hiding this comment.
Yes we probably should standardise, either to have the suffix or not have it. I don't have a strong feeling which way. With and without are both correct. I think I'd rather we leave it out everywhere. @BethBigGive what do you think?
There was a problem hiding this comment.
Merged so will move question to ticket.
NoelLH
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test, with a simulated current date, visit a URL such as http://localhost:4200/?simulatedDate=2023-11-28T12:00:00%2B00:00
The number at the end after
%2Bis the timezone offset from UTC - so keep it at zero if you just want to test for London in winter.