-
Notifications
You must be signed in to change notification settings - Fork 16
Adds cover image (and other small things) #63
base: master
Are you sure you want to change the base?
Adds cover image (and other small things) #63
Conversation
@mgan59 I think the action won't run because I've proposed from a fork, rather than a direct branch. Can we adjust the action so that works, or is this a limitation of GH Actions? |
I might have answered my own question. According to https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/ I need to change the action to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I've taken so long to review this, that this website repo has become deprecated, replaced by the hugo-website repo.
Lana, if there is anything of value in this pull request, I suggest that you re-apply it to the hugo-website repo.
Sorry for the slow review, and resulting extra work caused. I'll commit to review within a couple of weeks if you redo this in the hugo repo (and tell me of it).
I'll leave it to you Lana to decide whether you want this review approved here as well, but I'd suggest this request should be closed out with no action.
I don't have the time to handle this right now, sorry. Feel free to close it. If someone wants to take these images and add them to the new site, I'm happy for them to do so. |
This is a good first time issue for someone who wants to learn how to use git. |
Fixes: thegooddocsproject/templates#173
Purpose / why
Adds an image to the cover of the interactive IA Guide
What changes were made?
Verification
Checklist