refactor(sections, lint): Changing the sections to remove duplicate code and include all content in the page.tsx #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 7, 2024 21:07
… the page.tsx contains all the content I added those changes with the reasoning that most of the code is seperated from the context and remove repetitive code
…th eslint so that it runs automatically
andraghetti
approved these changes
Dec 8, 2024
There was a problem hiding this comment.
Great job! For the sections, it's definitely much better code, but I suppose we shouldn't keep that style and probably render them differently. I have no ideas, but I have a friend that is a great designer. He said he could help me with that.
Merge whenever you want. Let me know if I should fix the conflicts and merge instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for all the codebase it rocks 🎸.
Here I changed the sections to separate code/formating from content. Let me know your thoughts @andraghetti I can make a different structure if it is to your liking.
Also I added prettier to have a more readable code.
Since there is also linting, check this commit for the file changes related to the structure.