Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
Description
This PR addresses issue #129 by adding a
factorial2
function that wrapsscipy.special.factorial2
to return 1.0 when the input is not positive. This is temporary additional, while we wait for Scipy's update. To learn more, see scipy/scipy#18409. This function is added ingbasis.utils
(I tried adding it togbasis.wrappers
first but that would cause circular imports).Just patching scipy version (as was done in f74123e) was not enough, because unless you install the
gbasis
package, the correct version ofscipy
is not used causing headache. Also, one might need to use scipy1.11.x
in their environment for other purposes. In the meanwhile, correcting thefactorial2
output seems to me a more practical solution than patching the scipy version.Type of Changes
Related Issue
Closes #129