ASoC: SOF: ipc4: Add support for split firmware releases #5270
Conversation
ujfalusi
requested review from
lgirdwood,
plbossart,
ranj063,
kv2019i,
dbaluta and
bardliao
as code owners
sound/soc/sof/ipc4-loader.c
Outdated
|
|
||
| kfree(lib_filename); | ||
| if (ret) | ||
| break; |
There was a problem hiding this comment.
why break? If any of the libraries fail loading you don't attempt the rest? In this case it kind of makes sense - if there's no "main" module bundle, there's probably no "debug" either, but isn't the general concept - here's a list of optional libraries, we try to load whatever is available?
There was a problem hiding this comment.
The sof_ipc4_load_library() will only return error if there were real error for the loading, the bundle not present is not an error, but if the bundle loading fails then that is an error, something is not right and we will abort the probing altogethe.
There was a problem hiding this comment.
We should continue if a bundle fails, this way we still get base FW (and it may have some built-in modules) and a registered sound card. Yes we tell the user that we could not load the library and audio may not fully work as expected.
There was a problem hiding this comment.
We will fail to probe the card as the modules form the failed library are missing and the topology will not probe.
There was a problem hiding this comment.
OK, if we continue then the car will not come up, but the debugfs for SOF is going the be there to provide further clues.
ujfalusi
force-pushed
the
peter/sof/pr/ipc4-modular-sof-01
branch
from
36acd21 to
1664690
Compare
|
Changes since v1:
|
ujfalusi
force-pushed
the
peter/sof/pr/ipc4-modular-sof-01
branch
from
1664690 to
d09062a
Compare
|
Changes since v2:
|
ujfalusi
force-pushed
the
peter/sof/pr/ipc4-modular-sof-01
branch
from
d09062a to
2096214
Compare
|
Changes since v3:
|
sound/soc/sof/ipc4-loader.c
Outdated
| ret = firmware_request_nowarn(&fw_lib->sof_fw.fw, lib_filename, | ||
| sdev->dev); | ||
| if (ret < 0) { | ||
| dev_dbg(sdev->dev, "Library file '%s' is not present\n", |
There was a problem hiding this comment.
@ujfalusi with the current releases where the openmodule/debug binaries are absent, will we always see this debug message? I think this will too much of a distraction. How about we check the presence of these files before requesting to load the libraries?
There was a problem hiding this comment.
Or not print here at all if does not exist...
ujfalusi
force-pushed
the
peter/sof/pr/ipc4-modular-sof-01
branch
from
2096214 to
8760089
Compare
|
Changes since v4:
|
ujfalusi
changed the title
sound/soc/sof/ipc4-loader.c
Outdated
| * sof_ipc4_load_library_bundles - loads the library parts of a modular firmware | ||
| * @sdev: SOF device | ||
| * | ||
| * With IPC4 the firmware can be monolithic or modular release. |
There was a problem hiding this comment.
@ujfalusi you want to remove the monolithic reference in this PR too?
There was a problem hiding this comment.
yes, I wanted to... ;)
ujfalusi
force-pushed
the
peter/sof/pr/ipc4-modular-sof-01
branch
from
8760089 to
8bc8b0c
Compare
A split SOF release consists of a base firmware and two libraries: <fw_filename>-openmodules.ri for processing (audio) modules <fw_filename>-debug.ri for debug and developer modules To handle this new release model add infrastructure to try to load the two library after boot optionally. This approach will allow flexibility on handling platforms in sof-bin with single or split configuration: single release: base firmware only split release: base firmware + openmodules + debug The files for the split firmware are located at the firmware directory. Signed-off-by: Peter Ujfalusi <[email protected]>
|
Changes since v5:
|
|
SOFCI TEST |
1 similar comment
|
SOFCI TEST |
A split SOF release consists of a base firmware and two libraries:
<fw_filename>-openmodules.ri for processing (audio) modules
<fw_filename>-debug.ri for debug and developer modules
To handle this new release model add infrastructure to try to load the two
library after boot optionally.
This approach will allow flexibility on handling platforms in sof-bin with
single or split configuration:
single release: base firmware only
split release: base firmware + openmodules + debug
The files for the split firmware are located at the firmware directory.
The documentation update is: thesofproject/sof-docs#505