ASoC: SOF: ipc4-topology: Improve the information in prepare_copier p… #5286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ujfalusi
requested review from
lgirdwood,
plbossart,
ranj063,
kv2019i,
dbaluta and
bardliao
as code owners
lgirdwood
previously approved these changes
Jan 8, 2025
ranj063
previously approved these changes
Jan 8, 2025
bardliao
reviewed
Jan 9, 2025
sound/soc/sof/ipc4-topology.c
Outdated
| struct sof_ipc4_pipeline *pipeline; | ||
|
|
||
| dev_dbg(sdev->dev, | ||
| "Host copier %s, type %d, , ChainDMA: %s, stream_tag: %d\n", |
There was a problem hiding this comment.
Is the second comma in type %d, , redundant?
There was a problem hiding this comment.
Oh, yes, I will fix it asap
ujfalusi
force-pushed
the
peter/sof/pr/ipc4-topology-better-copier-prints-01
branch
from
d301dbd to
f1b7eb2
Compare
…rints It is useful to know the explicit type and if the copier (host/dai) is configured to use ChainDMA or not and also the stream_tag for the host copier. Change the prints to carry more information for debugging purposes. Signed-off-by: Peter Ujfalusi <[email protected]>
|
Changes since v1:
|
bardliao
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rints
It is useful to know the explicit type and if the copier (host/dai) is configured to use ChainDMA or not and also the stream_tag for the host copier.
Change the prints to carry more information for debugging purposes.