sof_remove: unload snd_sof_intel_hda_common before soundwire_intel
#1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Known ALSABAT failure in https://sof-ci.01.org/softestpr/PR1182/build356/devicetest/index.html Everything else green. |
plbossart
requested changes
Apr 29, 2024
tools/kmod/sof_remove.sh
Outdated
| @@ -120,6 +120,7 @@ remove_module snd_soc_hda_codec | |||
| # platform drivers | |||
| #------------------------------------------- | |||
| remove_module snd_sof_intel_hda_generic | |||
| remove_module snd_sof_intel_hda_common | |||
There was a problem hiding this comment.
I am pretty sure this does not work if you have snd_sof_intel_hda_sdw_bpt in use.
See thesofproject/linux@af779a3#diff-117faa254cc1264b915358fff9c601a8b15e7545c3, the BPT stuff depends on the hda_common stuff.
so if you want to deal with older kernels, you can add this line and ignore errors, and keep it line 136 where it was.
Fixes this failure with older kernel like the 6.5 kernels distributed by Ubuntu: ERROR: Module soundwire_intel is in use by: snd_sof_intel_hda_common Fixes commit 65951c4 ("kmod: fix hda-sdw-bpt dependency") which unloaded all soundwire drivers earlier as a block. This is not a problem with 6.9-ish kernels where snd_sof_intel_hda_common and soundwire_intel can apparently be unloaded in any order but it is a problem with older kernels. So, unload `snd_sof_intel_hda_common` before soundwire modules to be compatible with any kernel. See thesofproject#1156 for more info.
marc-hb
force-pushed
the
hda-common-before-sdw
branch
from
a1c3677 to
15e83e4
Compare
plbossart
approved these changes
Apr 30, 2024
|
Pretty bad looking but isolated and unrelated crash of Everything else 100% green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this failure with older kernel like the 6.5 kernels distributed by Ubuntu:
Fixes commit 65951c4 ("kmod: fix hda-sdw-bpt dependency") which unloaded all soundwire drivers earlier as a block. This is not a problem with 6.9-ish kernels where snd_sof_intel_hda_common and soundwire_intel can apparently be unloaded in any order but it is a problem with older kernels.
So, unload
snd_sof_intel_hda_commonbefore soundwire modules to be compatible with any kernel.See #1156 for more info.