test-speaker: add argument for loop count #677
Conversation
The existed '-l' is for nloops of speaker-test, which is used to configure the loop number of left/right .wav files in each playback, it is not suitable for the loop count for the speaker-test stress. Change the old speaker-test one to '-L' and add new '-l' for stress test purpose, to make it consistent with stress test of other cases. Signed-off-by: Keyon Jie <[email protected]>
keyonjie
requested review from
XiaoyunWu6666,
aiChaoSONG,
keqiaozhang and
marc-hb
|
|
||
| dlogc "speaker-test -D $dev -r $rate -c $channel -f $fmt -l $tcnt -t wav -P 8" | ||
| speaker-test -D $dev -r $rate -c $channel -f $fmt -l $tcnt -t wav -P 8 2>&1 |tee $LOG_ROOT/result_$loop_$idx.txt | ||
| resultRet=$? |
There was a problem hiding this comment.
I realize the code was already like this before this PR but here resultRet=$? is not the exit code of speaker-test, it's the exit code of the tee command/ which is useless - more green failures and untested test code yet again.
Please make sure this test fails when speaker test fails and fix it first if it does not; there's no point enhancing a test that does not even report failures in the first place. A very simple way to test the test is to temporarily pass a broken parameter.
Isn't a simple speaker-test || die enough? Do we really need these log files? Does speaker-test not use the exit code to report errors?
| OPT_NAME['l']='loop' OPT_DESC['l']='stress loops count' | ||
| OPT_HAS_ARG['l']=1 OPT_VAL['l']=1 | ||
|
|
||
| OPT_NAME['L']='nloops' OPT_DESC['L']='option of speaker-test, loop number of .wav files, 0 = infinite' |
| @@ -20,8 +20,11 @@ source $(dirname ${BASH_SOURCE[0]})/../case-lib/lib.sh | |||
| OPT_NAME['t']='tplg' OPT_DESC['t']='tplg file, default value is env TPLG: $TPLG' | |||
| OPT_HAS_ARG['t']=1 OPT_VAL['t']="$TPLG" | |||
|
|
|||
| OPT_NAME['l']='loop' OPT_DESC['l']='option of speaker-test' | |||
| OPT_HAS_ARG['l']=1 OPT_VAL['l']=3 | |||
| OPT_NAME['l']='loop' OPT_DESC['l']='stress loops count' | |||
There was a problem hiding this comment.
"stress loops count" would apply to either option, please use a description that makes a difference with the other option. Maybe something like "How many times speaker-test is run" versus "speaker-test --nloops option"
marc-hb
added
type:enhancement
|
Can one of the admins verify this patch?
|
The existed '-l' is for nloops of speaker-test, which is used to
configure the loop number of left/right .wav files in each playback, it
is not suitable for the loop count for the speaker-test stress.
Change the old speaker-test one to '-L' and add new '-l' for stress test
purpose, to make it consistent with stress test of other cases.
Signed-off-by: Keyon Jie [email protected]