Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: alow getRoles to be async #125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: alow getRoles to be async #125

wants to merge 1 commit into from

Conversation

lucasdidur
Copy link

To create a new Service Autenticator for firebase and get roles directly from database, getRoles functions need to be async

async getRoles(req: express.Request) {
    let user = await getRepository(User).findById(req.user as string);
    return [user.userType.toString()];
}

@codecov
Copy link

codecov bot commented Feb 26, 2020

Codecov Report

Merging #125 into master will increase coverage by <.01%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
+ Coverage   94.41%   94.41%   +<.01%     
==========================================
  Files          14       14              
  Lines        1128     1129       +1     
  Branches      204      204              
==========================================
+ Hits         1065     1066       +1     
  Misses         63       63
Impacted Files Coverage Δ
src/server/model/server-types.ts 100% <ø> (ø) ⬆️
src/authenticator/passport.ts 100% <100%> (ø) ⬆️
src/server/server-container.ts 87.86% <87.5%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3b45df...2fc5c42. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant