Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New theme - Flat #96

Merged
merged 5 commits into from
May 15, 2013
Merged

New theme - Flat #96

merged 5 commits into from
May 15, 2013

Conversation

jenil
Copy link
Contributor

@jenil jenil commented May 4, 2013

Hey Thomas!
I loved your project Bootswatch and to test it out I made a new theme 'Flat' which has colors and few styles based on the Flat UI pack by Designmodo.

Well I'd just like to contribute :)

Here's a peak

bootswatch flat

@thomaspark
Copy link
Owner

Hey Jenil, love the idea of a flat theme! What you have so far is great. Let's work together to make this happen, with all due credit to you. Some comments:

  • A different name can make it much easier to search for. How about Flatness?
  • Some of the overrides in bootswatch.less can be done more succinctly in variables.less. For instance, in variables.less, you can set the color variables and then use those to set button colors. This will reduce the size of the stylesheets and make maintenance easier.
  • Alerts aren't styled, but this can also be done easily through variables.less.
  • The base font-size could be bumped up by a couple of pixels.
  • Color scheme is great, but the primary and success greens are similar. How about light gray for default buttons, blue (#33495E) for primary, green (#18BC9C) for success, and dark gray for inverse?
  • For small and mini buttons, the font-size should be decreased, like they are for the split buttons.
  • At least in the screenshot, there's some weirdness with the glyphs.

Otherwise, looks good! Let me know your thoughts on these. After some iteration, I can test the theme and then push it live.

* Change name to 'Flatness'
* Removes overides on buttons and they are now addes in variables.less
* Button and Navbar get new look
* Small and mini buttons getting smaller font
* fixed duplicate icons issue
* Overall font size increased
* Alerts styles improved
@jenil
Copy link
Contributor Author

jenil commented May 9, 2013

Hey Thomas!
I'm glad you liked the theme!

  • Flatness sounds great!
  • Removes overides on buttons and they are now addes in variables.less
  • Button and Navbar get new look
  • Small and mini buttons getting smaller font
  • Fixed duplicate icons issue
  • Overall font size increased
  • Alerts styles improved

Let me know how you like it!

@thomaspark
Copy link
Owner

@jenil27 Looks good, I'll probably make some minor changes to give consistency with the other themes, then add it to the front page.

thomaspark added a commit that referenced this pull request May 15, 2013
@thomaspark thomaspark merged commit a0301ec into thomaspark:gh-pages May 15, 2013
@jenil
Copy link
Contributor Author

jenil commented May 15, 2013

@thomaspark Cool! You would have to updated the thumbnail. Also, I would be thankful to you if I had my name in the footer for this theme :)

@thomaspark
Copy link
Owner

Tweaked some styles, refactored/reformatted code to be consistent with other themes, and styled additional components (subnav, pagination, alerts, pager, responsive).

Also added your name as a credit on the preview page, and will mention it again on the blog announcement.

Sneak preview: http://bootswatch.com/flatly/

@frapontillo
Copy link
Contributor

This new theme is really amazing, updating on NuGet right now! :)

node_modules
build
.DS_Store
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to remove build, components, and .idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants