fix: copied div margin-top #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just noticed that the icons and the white band were overlapping at times when the icon was big. I have bummed up the margin-top a bit to fix this issue.
|
Thanks. We should make this overlay more responsive at some point. |
|
I think it is pretty responsive, because the overlay doesn't show up on mobiles and tablets which don't support flash anyway. |
|
But people on PCs have windows in all sorts of configurations, especially for a utility site like this. It wouldn't take much to ensure the overlay is centered and displayed nicely at all sizes. |
|
I checked it, it works well only issues is we need to reduce the font-size with respect to the viewport. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just noticed that the icons and the white band were overlapping at times when the icon was big. I have bummed up the margin-top a bit to fix this issue.