Fix the discord external url #792
Conversation
evandrosaturnino
requested review from
Shadowfiend,
lukasz-zimnoch and
michalsmiarowski
src/enums/externalHref.ts
Outdated
| @@ -1,6 +1,6 @@ | |||
| export enum ExternalHref { | |||
| thresholdGithub = "https://github.com/threshold-network/token-dashboard", | |||
| thresholdDiscord = "https://discord.gg/WXK9PC6SRF", | |||
| thresholdDiscord = "https://discord.gg/threshold", | |||
There was a problem hiding this comment.
Discord custom invite URLs are not reserved if the server loses boost status, so they are an attack vector.
We can and may already have a discord.threshold.network or chat.threshold.network that gives us a branded URL under our own control. We've done this switch in other places including maybe some parts of the Threshold sites.
There was a problem hiding this comment.
I wasn’t aware that we had a subdomain redirecting to the Discord invite URL: https://discord.threshold.network/. This URL appears to be working correctly, so for this PR, this has been adressed on update discord url to branded subdomain
I checked, and we don’t currently use this subdomain URL on the Threshold website. I’ve pushed a PR to address this as well: threshold-network/website#127.
|
Preview uploaded to https://preview.dashboard.test.threshold.network/fix-discord-external-url/index.html. |
Description
Fix the Discord external url
Type of change
Notice