survival_prob_orsf() should take a parnip model
#283
Comments
bcjaeger
added a commit
to bcjaeger/censored
that referenced
this issue
Dec 28, 2023
Merged
bcjaeger
added a commit
to bcjaeger/censored
that referenced
this issue
Dec 29, 2023
bcjaeger
added a commit
to bcjaeger/censored
that referenced
this issue
Jan 3, 2024
bcjaeger
added a commit
to bcjaeger/censored
that referenced
this issue
Jan 3, 2024
I mean it this time.
hfrick
added a commit
that referenced
this issue
Jan 5, 2024
* modify tests for version 1.1.2 * parsnip object in survival_prob; see #283 * require version 0.1.2 or higher * use remote to get aorsf * use parsnip obj in example * update docs w/aorsf example * modify tests for version 0.1.2 * parsnip object in survival_prob; see #283 * require version 0.1.2 or higher * use remote to get aorsf * use parsnip obj in example * update docs w/aorsf example * revert changes for #283 * fix predict call predict() uses direct args for aorsf's predict function here, so I reverted back to using object$fit * revert my changes for #283 I mean it this time. * forgot to update docs * make tests version-agnostic --------- Co-authored-by: Hannah Frick <[email protected]>
|
I had my glmnet googles on when I opened that issue: the functions for coxnet models are the only ones that take a parsnip model fit rather than an engine fit. Nonetheless, that's an inconsistency. Closing this issue in favor of #295 for a holistic view of the problem. |
|
This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The other
survival_prob_*()functions all take anobjectof classmodel_fitwhilesurvival_prob_orsf()takes an object that's the engine fit, i.e., of class"orsf". For consistency, this should also be a parsnip model.The text was updated successfully, but these errors were encountered: