Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove print._coxnet() #313

Merged
merged 3 commits into from
Apr 15, 2024
Merged

remove print._coxnet() #313

merged 3 commits into from
Apr 15, 2024

Conversation

EmilHvitfeldt
Copy link
Member

I'm not able easily find the origin of this function. but as it stands it appears to have been a near copy of the old print.model_fit().

The other errors appears to be related to tidymodels/parsnip#1109

@simonpcouch
Copy link
Contributor

It does seem like some "The training data has been saved for prediction." lines are being removed in snaps. Unless this is blocking you on a parsnip PR, I'll defer to @hfrick on reviewing this one, as she's more likely to understand how important it is that we call that out.

@hfrick
Copy link
Member

hfrick commented Apr 12, 2024

That line is the reason for this print method to exist :) Could you update it rather than remove it?

@EmilHvitfeldt
Copy link
Member Author

I used NextMethod() to make it so print.model_fit() is in charge of the actually printing, and print._coxnet() only adds extra.

@hfrick
Copy link
Member

hfrick commented Apr 15, 2024

Excellent, thank you! 🙌 I've taken that idea just a smidge further, leaning into the parnsip method for everything but that one extra sentence.

@hfrick hfrick merged commit ebda76c into main Apr 15, 2024
10 checks passed
@hfrick hfrick deleted the remove-print-coxnet branch April 15, 2024 12:02
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants