DNM: feat: support metrics log stream #28
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airkei
commented
Jan 9, 2025
Comment on lines
+240
to
+247
| @computed_field | ||
| @property | ||
| def aws_cloudwatch_metrics_log_group(self) -> str: | ||
| return ( | ||
| f"/aws/greengrass/edge/{self.region}/" | ||
| f"{self.account_id}/{self.profile}-edge-otaclient-metrics" | ||
| ) | ||
|
|
There was a problem hiding this comment.
new log group name for metrics
airkei
commented
Jan 9, 2025
| from queue import Queue | ||
| from typing import Literal, TypedDict | ||
|
|
||
| from typing_extensions import NotRequired, TypeAlias | ||
|
|
||
| LogsQueue: TypeAlias = "Queue[tuple[str, LogMessage]]" | ||
| LogsQueue: TypeAlias = "Queue[tuple[LogGroupType, str, LogMessage]]" |
There was a problem hiding this comment.
change the data format of the queue.
airkei
commented
Jan 9, 2025
| @@ -76,10 +76,13 @@ def generate_random_msgs( | |||
| ) -> list[tuple[str, LogMessage]]: | |||
| _res: list[tuple[str, LogMessage]] = [] | |||
| for _ in range(msg_num): | |||
| _ecu, *_ = random.sample(ecus_list, 1) | |||
| _ecu_id, *_ = random.sample(ecus_list, 1) | |||
| _log_group_type = random.choice(list(LogGroupType)) | |||
There was a problem hiding this comment.
test both log group type.
airkei
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should be merged after #27.
Why
https://tier4.atlassian.net/browse/RT4-13461
This PR support a new log group for metrics.
The reason why we switch the log group is that AWS subscription filter apply its filter based on the target log group level. Thus, by dividing log group, cloudwatch can apply the filter efficiently.
The log group name for metrics will be
/aws/greengrass/edge/{self.region}/{self.account_id}/{self.profile}-edge-otaclient-metrics, log stream name will be same as the existing log stream name.What
Change the existing data format in the queue and add
LogGroupTypefield.Once logging thread receives the log group type, handle the target log group based on it.
Test
Verified that the modified pytests are passed.