HW 4 is completed #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timersha
force-pushed
the
hw04_lru_cache
branch
from
5405173 to
627eae1
Compare
agneum
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Прошу, чтобы PR содержал только файлы, относящиеся к текущему ДЗ
Comment on lines
+51
to
+54
| v = lruC.queue.PushFront(value) | ||
| v.Value = &CacheItem{key, value} | ||
| lruC.items[key] = v | ||
| lruC.cleanOutdatedElements() |
There was a problem hiding this comment.
Формально корректнее сначала проверить размер списка, а затем добавлять элемент, чтобы не превысить лимит
| } | ||
|
|
||
| func (lruC *lruCache) Clear() { | ||
| l := lruC.queue.Len() |
There was a problem hiding this comment.
Не хватает лока на время очистки
Comment on lines
+73
to
+76
| for range l { | ||
| delete(lruC.items, lruC.queue.Front().Value.(*CacheItem).k) | ||
| lruC.queue.Remove(lruC.queue.Front()) | ||
| } |
There was a problem hiding this comment.
Выполняется полный перебор списка.
Рекомендовал бы вместо этого переинициализировать поля списка как при создании
| "strconv" | ||
| "sync" | ||
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/require" | ||
| "golang.org/x/exp/rand" |
There was a problem hiding this comment.
Почему заменён пакет rand?
| newFront := &ListItem{ | ||
| Value: v, | ||
| Next: l.front, | ||
| Prev: nil, |
There was a problem hiding this comment.
Поля с zero-value можно не указывать явно
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Домашнее задание №4 «LRU-кэш»
Чек-лист студента (Что это?)
go mod tidy..syncфайл. Зачем его удалять?Критерии оценки
выталкивания из кэша редко используемых элементов) - до 3 баллов
Зачёт от 7 баллов