Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use Date to parse due_date for GitlabIssue like GitlabMilestone #355

Merged
merged 2 commits into from
Oct 18, 2019
Merged

use Date to parse due_date for GitlabIssue like GitlabMilestone #355

merged 2 commits into from
Oct 18, 2019

Conversation

pikuzi
Copy link
Contributor

@pikuzi pikuzi commented Jul 4, 2019

This PR was proposed to fix the issue of due_date parse issue.

#350

@pikuzi
Copy link
Contributor Author

pikuzi commented Jul 4, 2019

close this PR until got the tests fixed.

@pikuzi pikuzi closed this Jul 4, 2019
@pikuzi pikuzi reopened this Jul 4, 2019
@pikuzi
Copy link
Contributor Author

pikuzi commented Jul 4, 2019

complete the commit.
Proposed solution: use Date to parse due_date in GitlabIssue like GitlabMilestone.

@timols timols merged commit b6e8890 into timols:master Oct 18, 2019
@cowtowncoder
Copy link

Something went wrong here, wrt #351.

@cowtowncoder cowtowncoder mentioned this pull request Oct 18, 2019
Merged
@timols
Copy link
Owner

timols commented Oct 26, 2019

@pikuzi I had to revert this change due to test failures and @cowtowncoder's point regarding breaking API changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pikuzi @cowtowncoder @timols