Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: prepare custom runtimes #98

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AriPerkkio
Copy link
Member

@AriPerkkio AriPerkkio commented Jun 23, 2024

Refactors internal runtime APIs. Preparation for making runtime APIs public for custom runtimes, e.g. Vitest browser mode runtime.

Codebase of piscina is really complex. 😢

@Aslemammad
Copy link
Member

excited for this one, it means tinypool browser support soon?

@AriPerkkio
Copy link
Member Author

AriPerkkio commented Jun 24, 2024

This (and the next PR that actually opens custom runtime API) does expand Tinypool's usage to such use cases. But for Vitest browser mode, @sheremet-va has a bit different idea. Tinypool would be used as orchestrator, and Vitest itself would provide the runtime layer that would use web sockets to communicate with browser entrypoint.

These changes also make it possible to add generic browser support into Tinypool. Pool itself has to run on Node though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants