Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to criterion 0.5.1 #223

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

rillian
Copy link

@rillian rillian commented Mar 12, 2024

Migrate to the latest version of the benchmark library. No code changes required.

Addresses two audit warnings:

Note that this requires an MSRV bump to 1.63.0 for the atty replacement.

rillian added 2 commits March 12, 2024 15:38
Migrate to the latest version of the benchmark library.
No code changes required.

Addresses two audit warnings:

- atty is unmaintained and 0.2.14 is unsound
  https://rustsec.org/advisories/RUSTSEC-2021-0145
- serde_cbor is unmaintained
  https://rustsec.org/advisories/RUSTSEC-2021-0127
Update the declared minimum rust version for compatibility
with `is-terminal` v0.4.12. Note that integration tests
currently run for nightly, stable, and 1.72.0 which are
rather more recent.
@tkaitchuck tkaitchuck changed the base branch from master to 0.9-prerelease March 20, 2024 02:41
@tkaitchuck tkaitchuck self-requested a review March 20, 2024 02:41
@tkaitchuck tkaitchuck merged commit af37d79 into tkaitchuck:0.9-prerelease Mar 20, 2024
9 checks passed
@rillian
Copy link
Author

rillian commented Mar 20, 2024

Thanks!

@rillian rillian deleted the criterion-0.5 branch March 20, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants