fix(platform): cluster status is Terminating, update will delete it (#…

…2304)

Co-authored-by: xdonggao <[email protected]>

pkg/platform/registry/cluster/storage/storage.go

@@ -73,6 +73,8 @@ func NewStorage(optsGetter genericregistry.RESTOptionsGetter, platformClient pla
 		UpdateStrategy: strategy,
 		DeleteStrategy: strategy,
 
+		ShouldDeleteDuringUpdate: clusterstrategy.ShouldDeleteDuringUpdate,
+
 		TableConvertor: printerstorage.TableConvertor{TableGenerator: printers.NewTableGenerator().With(AddHandlers)},
 	}
 	options := &genericregistry.StoreOptions{

pkg/platform/registry/cluster/strategy.go

@@ -30,6 +30,7 @@ import (
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/apimachinery/pkg/util/validation/field"
 	genericregistry "k8s.io/apiserver/pkg/registry/generic"
+	"k8s.io/apiserver/pkg/registry/generic/registry"
 	"k8s.io/apiserver/pkg/registry/rest"
 	"k8s.io/apiserver/pkg/storage"
 	"k8s.io/apiserver/pkg/storage/names"
@@ -251,6 +252,15 @@ func MatchCluster(label labels.Selector, field fields.Selector) storage.Selectio
 	}
 }
 
+func ShouldDeleteDuringUpdate(ctx context.Context, key string, obj, existing runtime.Object) bool {
+	app, ok := obj.(*platform.Cluster)
+	if !ok {
+		log.Errorf("unexpected object, key:%s", key)
+		return false
+	}
+	return len(app.Spec.Finalizers) == 0 && registry.ShouldDeleteDuringUpdate(ctx, key, obj, existing)
+}
+
 // ToSelectableFields returns a field set that represents the object
 func ToSelectableFields(cluster *platform.Cluster) fields.Set {
 	objectMetaFieldsSet := genericregistry.ObjectMetaFieldsSet(&cluster.ObjectMeta, false)