fix disappearing fingerprints #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Damien Doligez <[email protected]>
damiendoligez
force-pushed
the
fix-disappearing-fingerprints
branch
from
b226b18 to
d080a44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the problem reported here: tlaplus/Examples#67 (comment)
The problem is that checking
ReachableProofs.tlaerases the saved fingerprints ofReachabilityProofs.tla. More generally, when checking the proofs for one file,tlapmmay have to parse other files that contain proofs. Those proofs are not re-checked becausetlapmonly checks the proofs inside the files that are explicitly given on the command line. Here, the proofs are not checked, but the (empty) fingerprint set is still written to disk, erasing the existing fingerprints.This bug was introduced in 1938a78 by the fix for another bug.