Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add output buffer argument to deplane_simd #145

Merged
merged 5 commits into from
Mar 9, 2024

Conversation

chrstphrbrns
Copy link
Contributor

Optimize the predictor == 3 case, where deplane is called for every row

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6bfae1c) 93.04% compared to head (b729b67) 93.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
+ Coverage   93.04%   93.09%   +0.05%     
==========================================
  Files          13       13              
  Lines        1092     1101       +9     
==========================================
+ Hits         1016     1025       +9     
  Misses         76       76              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrstphrbrns
Copy link
Contributor Author

I was optimistic that checking for alignment would solve the vload issue, but I've needed to disable deplane_simd! for x64 mac and windows. I don't believe we've seen it happen with the Ubuntu CI tests, and I'm not able to repro on my AMD Linux or M1 Mac machines

@tlnagy
Copy link
Owner

tlnagy commented Feb 27, 2024

Hi @chrstphrbrns, sorry the delay, is this ready to merged? I was hoping to push out v0.9.0 with this included.

@chrstphrbrns
Copy link
Contributor Author

Yes, this is ready

@tlnagy tlnagy merged commit c7003a7 into tlnagy:master Mar 9, 2024
12 of 13 checks passed
@chrstphrbrns chrstphrbrns deleted the chris/deplane branch March 9, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants