Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ESP32 Core 3 compatibility #234

Merged
merged 1 commit into from
Jun 4, 2024
Merged

fix: ESP32 Core 3 compatibility #234

merged 1 commit into from
Jun 4, 2024

Conversation

vlastahajek
Copy link
Collaborator

@vlastahajek vlastahajek commented Jun 4, 2024 •
edited
Loading

Closes #226

Proposed Changes

Added explicit includes which were part of HTTPClient.h in ESP32 core 2.x.x

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are in semantic format

@vlastahajek vlastahajek merged commit 65b5e9e into master Jun 4, 2024
1 check passed
@vlastahajek vlastahajek deleted the fix/esp32-3.0.0 branch June 4, 2024 20:22
@vlastahajek vlastahajek mentioned this pull request Jun 4, 2024
Closed
@jezmck
Copy link

jezmck commented Jun 7, 2024

Phew, I thought I was going insane!
I was already adding the removed libs for my own code, so was very confused by the error messages.

Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Library fails to compile on framework-arduinoespressif32 @ 3.0.0
2 participants
@vlastahajek @jezmck