Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move to rustc fx hashmap #4588

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

benfdking
Copy link
Collaborator

@benfdking benfdking commented Jan 9, 2025

mostly just to test the benchmark job but this improves parsing performance by 17% on long.

@benfdking
Copy link
Collaborator Author

Works but can't comment from a fork

image

Copy link
Collaborator

@georgesittas georgesittas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tobymao waiting for you to take a look here before merging. Even though rustc-hash is under dependencies, my understanding is that this should be fine because:

  1. It is used in rustc itself, see repo.
  2. We pre-compile the rust tokenizer and ship the various binaries when releasing sqlglotrs, so users shouldn't encounter any dependency issues. @benfdking to verify. Could there be linking issues with this library at runtime?

@benfdking
Copy link
Collaborator Author

I don't expect this to affect anything. For those who don't have prebuilt binaries, python will build it with cargo and there it is done without any user intervention so no more invasive than what's there already.

@georgesittas georgesittas merged commit bc9975f into tobymao:main Jan 10, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants