Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests files in MANIFEST #56

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jcapiitao
Copy link
Contributor

Those files are required for distribution packaging, as we need to run the tests during the package build.

@gasman
Copy link
Member

gasman commented Nov 19, 2024

Thanks @jcapiitao!
A potential issue here is that someone installing the source package will end up with a tests module at the top level of their site-packages. Do we need to perhaps consider moving this into a submodule of django_libsass (and then potentially adjusting the config so that django_libsass.tests is included in the source package but not the wheel)?

@jcapiitao
Copy link
Contributor Author

Oh right, we need to move core content and tests into django_libsass directory.
We can also include tests only in sdist and not wheel, do you want me to work on that in this PR ? or should I open new one ?

@gasman
Copy link
Member

gasman commented Nov 19, 2024

Yes please - having those updates as part of this PR makes most sense, I think.

Those files are required for distribution packaging, as we need to
run the tests during the package build.
@jcapiitao jcapiitao force-pushed the add_test_files_in_source_distribution branch from c34b46a to a7f9074 Compare November 20, 2024 08:19
@jcapiitao
Copy link
Contributor Author

With latest commit, we have tests/ folder in source distribution but not the wheel. And top level is django_libsass with just the content in __init__.py.

ls -l .venv/lib/python3.12/site-packages/django_libsass
__init__.py
__pycache__
less dist/django-libsass-0.9.tar.gz
django-libsass-0.9/LICENSE
django-libsass-0.9/MANIFEST.in
django-libsass-0.9/PKG-INFO
django-libsass-0.9/README.rst
django-libsass-0.9/django_libsass/
django-libsass-0.9/runtests.py
django-libsass-0.9/setup.cfg
django-libsass-0.9/setup.py
django-libsass-0.9/tests/
django-libsass-0.9/tox.ini

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants