Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/check screen #1640

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Hotfix/check screen #1640

merged 2 commits into from
Jan 10, 2025

Conversation

renanllisboa
Copy link
Member

This pull request introduces several new methods to improve the handling of screen elements and selectors in the tir/technologies/webapp_internal.py file. The changes focus on adding methods to check the presence of various screens and to retrieve their selectors, as well as updating existing methods to utilize these new methods.

New methods for handling screen elements and selectors:

  • Added check_screen_element, coin_screen_selectors, warning_screen_selectors, news_screen_selectors, browse_screen_selectors, and get_screen_selectors methods to check and retrieve selectors for different screens.
  • Added check_browse_screen, check_coin_screen, check_warning_screen, check_news_screen, and check_screen methods to check if specific screens are displayed.

Updates to existing methods:

  • Updated close_coin_screen to use the new coin_screen_selectors and check_coin_screen methods.
  • Updated close_coin_screen_after_routine to check if any screen is displayed using the new check_screen method.
  • Updated close_warning_screen to use the new warning_screen_selectors and check_warning_screen methods.
  • Updated close_warning_screen_after_routine to check if any screen is displayed using the new check_screen method.
  • Updated close_news_screen to use the new news_screen_selectors and check_news_screen methods.
  • Updated close_news_screen_after_routine to check if any screen is displayed using the new check_screen method.

Enhancements to element_exists method:

  • Modified the element_exists method to set a default value for the main_container parameter if it is not provided. [1] [2]

@renanllisboa renanllisboa merged commit 0028b6d into release/v1.20.30rc1 Jan 10, 2025
0 of 5 checks passed
@renanllisboa renanllisboa deleted the hotfix/check_screen branch January 10, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants