Use v:echospace to avoid hit-Enter prompts #285
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
commented
Oct 22, 2019
| endif | ||
|
|
||
| let msg_len = len(substitute(a:msg, '.', '.', 'g')) | ||
| if msg_len > max_cmd_len |
There was a problem hiding this comment.
Could also use strwidth maybe if available?
There was a problem hiding this comment.
Character length rather than byte length.
blueyed
commented
Oct 22, 2019
tpope
reviewed
Oct 22, 2019
tpope
reviewed
Oct 22, 2019
tpope
reviewed
Nov 16, 2019
|
|
||
| if exists('v:echospace') | ||
| if strwidth(a:msg.' '.a:suffix) > v:echospace | ||
| let msg = printf('%.*S...', v:echospace - 3 - len(a:suffix), a:msg) |
There was a problem hiding this comment.
This should use the < notation from the other format, not an ellipsis.
|
OK. Let's wait for @tpope then. Thanks |
|
If I was going to do it myself I would have done it myself rather than explicitly requesting changes. |
|
Ok @blueyed can you wrap this up then? It's really annoying to press enter. Thank you so much in advance |
|
Hi, @blueyed. Is there some advance on this? Thank you for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #166
Followup-to #167