Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: serialize agg state using kryo #714

Merged
merged 3 commits into from
Oct 30, 2023
Merged

feat: serialize agg state using kryo #714

merged 3 commits into from
Oct 30, 2023

Conversation

xzchaoo
Copy link
Contributor

@xzchaoo xzchaoo commented Oct 30, 2023 •
edited
Loading

Which issue does this PR close?

Closes #

Rationale for this change

What changes are included in this PR?

  • A simpler way to serialize state: use kryo to serialize agg state
  • Supports emitting incomplete data (preview mode)

Are there any user-facing changes?

How does this change test

@xzchaoo xzchaoo added the enhancement New feature or request label Oct 30, 2023
@xzchaoo xzchaoo requested a review from jsy1001de October 30, 2023 03:53
@xzchaoo xzchaoo self-assigned this Oct 30, 2023
@xzchaoo xzchaoo changed the title Feat kryo state feat: serialize agg state using kryo Oct 30, 2023
@xzchaoo xzchaoo requested a review from masaimu October 30, 2023 04:17
jsy1001de
jsy1001de approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@jsy1001de jsy1001de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xzchaoo xzchaoo merged commit b3e0579 into traas-stack:main Oct 30, 2023
47 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsy1001de jsy1001de jsy1001de approved these changes

@masaimu masaimu Awaiting requested review from masaimu

Assignees

@xzchaoo xzchaoo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xzchaoo @jsy1001de