Update response for schedule list #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuokada
reviewed
Jul 17, 2024
yuokada
approved these changes
Jul 18, 2024
Comment on lines
216
to
217
| ", engineVersion='" + engineVersion + '\'' + | ||
| ", executingUserid='" + executingUserId + '\'' + |
There was a problem hiding this comment.
Suggested change
| ", engineVersion='" + engineVersion + '\'' + | |
| ", executingUserid='" + executingUserId + '\'' + | |
| ", engineVersion=" + engineVersion + | |
| ", executingUserId=" + executingUserId + |
NIT: Single quotes aren't necessary.
ylzen
approved these changes
Jul 18, 2024
imnutz
force-pushed
the
update_response_for_schedule_list
branch
from
2b951b3 to
6eb1022
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
executing_user_idanddescriptionto the response