Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce show_danger #4404

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Introduce show_danger #4404

merged 1 commit into from
Dec 2, 2024

Conversation

ibz
Copy link
Contributor

@ibz ibz commented Nov 28, 2024 •
edited
Loading

This is a unified interface for flow_warning_hi_prio, which was available only on Mercury before.

@ibz ibz self-assigned this Nov 28, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

legacy UI changes device test(screens) main(screens)

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@ibz ibz linked an issue Nov 29, 2024 that may be closed by this pull request
Cleanup confirm_blob & related code #4386
Open
8 tasks
@ibz ibz force-pushed the ibz/20241128-danger branch from 135f9b0 to d8d236e Compare November 29, 2024 08:23
@ibz ibz marked this pull request as ready for review November 29, 2024 08:24
@ibz ibz requested review from matejcik and prusnak as code owners November 29, 2024 08:24
@ibz ibz requested review from obrusvit and removed request for prusnak November 29, 2024 08:24
@ibz ibz force-pushed the ibz/20241128-danger branch from d8d236e to cba2e08 Compare November 29, 2024 09:22
obrusvit
obrusvit reviewed Nov 29, 2024
View reviewed changes
Copy link
Contributor

@obrusvit obrusvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few points for discussion.

core/embed/rust/src/ui/model_mercury/flow/danger.rs Outdated Show resolved Hide resolved
core/src/trezor/ui/layouts/mercury/__init__.py Outdated Show resolved Hide resolved
core/src/trezor/ui/layouts/tt/__init__.py Outdated Show resolved Hide resolved
@Hannsek
Copy link
Contributor

Hannsek commented Dec 2, 2024

Why did the exclamation mark disappear from the "Warning" header.

Why did the text change from "cancel and exit" to "cancel"?

@ibz
Copy link
Contributor Author

ibz commented Dec 2, 2024

Why did the exclamation mark disappear from the "Warning" header.

For consistency. Now all of these warnings look the same. If you think they should all have the exclamation mark, I can add that. But the ETH contract design did not have it.

Why did the text change from "cancel and exit" to "cancel"?

Where?

@Hannsek
Copy link
Contributor

Hannsek commented Dec 2, 2024

Strange, I was looking at the diff this morning and it was like that. Also "important" had an exclamation mark, but "Warning" did not. Now everything is fine. Thank you.

matejcik
matejcik approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@matejcik matejcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK on code but something is wrong with UI tests

@ibz ibz force-pushed the ibz/20241128-danger branch from bbcaeb0 to 7873a24 Compare December 2, 2024 12:36
@obrusvit obrusvit force-pushed the ibz/20241128-danger branch from 7873a24 to b249ad4 Compare December 2, 2024 19:00
@obrusvit obrusvit added the translations Put this label on a PR to run tests in all languages label Dec 2, 2024
@ibz @obrusvit
refactor(core/ui): introduce show_danger
7765931 
This is a unified interface for flow_warning_hi_prio,
which was available only on Mercury before.

[no changelog]
@obrusvit obrusvit force-pushed the ibz/20241128-danger branch from b249ad4 to 7765931 Compare December 2, 2024 20:49
@obrusvit obrusvit merged commit 13df961 into main Dec 2, 2024
139 checks passed
@obrusvit obrusvit deleted the ibz/20241128-danger branch December 2, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obrusvit obrusvit obrusvit approved these changes

@matejcik matejcik matejcik approved these changes

Assignees

@ibz ibz

Labels
translations Put this label on a PR to run tests in all languages
Projects
Firmware
Status: ✅ Approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup confirm_blob & related code
4 participants
@ibz @Hannsek @matejcik @obrusvit