-
-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(core): add missing parameter to set_brightness function #4411
base: main
Are you sure you want to change the base?
Conversation
|
|
ack on code, please fix ui tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually don't think this fixes the issue, does it?
If you pass the value to the set_brightness
dialog, it merely starts the UI with the value. But the first real change happens on NumberInputSliderDialogMsg::Changed
which happens only if you change the number.
You are right, @obrusvit
|
Rebasing due to conflicts from the latest changes |
0537f0c
to
5091f3e
Compare
This PR:
set_brightness
function