Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor usb events #4426

Merged
merged 1 commit into from
Jan 13, 2025
Merged

refactor usb events #4426

merged 1 commit into from
Jan 13, 2025

Conversation

TychoVrahe
Copy link
Contributor

@TychoVrahe TychoVrahe commented Dec 6, 2024

This PR refactors how USB events (currently configured/deconfigured) are processed.

The new system is more in line with how other events, like touch or button, are processed, and allows easier addition of more events if needed (like connected/disconnected on battery powered devices perhaps).

Builds on #4419

@TychoVrahe TychoVrahe self-assigned this Dec 6, 2024
Copy link

github-actions bot commented Dec 6, 2024

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@TychoVrahe TychoVrahe force-pushed the tychovrahe/refactor/usb_events branch 2 times, most recently from 7d19ea9 to a355c19 Compare December 9, 2024 10:24
@TychoVrahe TychoVrahe marked this pull request as ready for review December 9, 2024 11:30
@TychoVrahe TychoVrahe requested review from cepetr and removed request for prusnak and matejcik December 9, 2024 11:31
core/embed/io/usb/stm32/usb.c Outdated Show resolved Hide resolved
core/embed/io/usb/stm32/usb.c Outdated Show resolved Hide resolved
Copy link
Contributor

@cepetr cepetr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, and everything appears to be working correctly.

@TychoVrahe TychoVrahe force-pushed the tychovrahe/refactor/usb_events branch from d45da63 to f5a0f84 Compare December 12, 2024 16:11
@TychoVrahe TychoVrahe force-pushed the tychovrahe/refactor/usb_split branch from 7d2f091 to c3e50d6 Compare January 13, 2025 15:56
Base automatically changed from tychovrahe/refactor/usb_split to main January 13, 2025 16:42
@TychoVrahe TychoVrahe force-pushed the tychovrahe/refactor/usb_events branch from f5a0f84 to aac111f Compare January 13, 2025 16:44
@TychoVrahe TychoVrahe removed the request for review from andrewkozlik January 13, 2025 16:45
@TychoVrahe TychoVrahe merged commit eef2f41 into main Jan 13, 2025
95 checks passed
@TychoVrahe TychoVrahe deleted the tychovrahe/refactor/usb_events branch January 13, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🤝 Needs QA
Development

Successfully merging this pull request may close these issues.

2 participants