Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure dependency between PIN and wipe code #4447

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Ensure dependency between PIN and wipe code #4447

wants to merge 2 commits into from
+97 −9

Conversation

bieleluk
Copy link
Contributor

@bieleluk bieleluk commented Dec 13, 2024 •
edited
Loading

This PR:

  • ensures that the wipe code can not be enabled without without PIN being active
  • ensures that the PIN cannot be turned off with the wipe code being active

Changes include:

  • change_pin function
    • in PIN removing scenario, adding extra check to ensure that the wipe code is turned off
    • if not the error screen is shown and the action is cancelled
  • change_wipe_code function
    • in wipe code creating scenario, adding extra check to ensure that the PIN is turned on
    • if not the error screen is shown and the action is cancelled
  • device tests for both scenarios

@bieleluk bieleluk self-assigned this Dec 13, 2024
@bieleluk bieleluk linked an issue Dec 13, 2024 that may be closed by this pull request
No dependency check between PIN and wipe code #4446
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2024 •
edited
Loading

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@bieleluk bieleluk force-pushed the bieleluk/pin-dependency branch from fa713a2 to 9f301c7 Compare December 16, 2024 13:35
@bieleluk bieleluk added the core Trezor Core firmware. Runs on Trezor Model T and T2B1. label Dec 16, 2024
@bieleluk bieleluk marked this pull request as ready for review December 16, 2024 13:43
@bieleluk bieleluk removed the request for review from prusnak December 16, 2024 13:43
@bieleluk bieleluk mentioned this pull request Dec 16, 2024
Draft
@bieleluk
Copy link
Contributor Author

Rebasing on top of a big change recently added to main

@bieleluk bieleluk force-pushed the bieleluk/pin-dependency branch from 9f301c7 to 6fca7ae Compare December 19, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejcik matejcik Awaiting requested review from matejcik matejcik is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@bieleluk bieleluk

Labels
core Trezor Core firmware. Runs on Trezor Model T and T2B1.
Projects
Firmware
Status: 🔎 Needs review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No dependency check between PIN and wipe code
1 participant
@bieleluk