Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suspend to low power mode on T3W1 #4454

Merged
merged 14 commits into from
Jan 14, 2025
Merged

Suspend to low power mode on T3W1 #4454

merged 14 commits into from
Jan 14, 2025

Conversation

cepetr
Copy link
Contributor

@cepetr cepetr commented Dec 19, 2024

This PR improves the handling of suspending and resuming to/from low power mode on T3W1, aiming to achieve the lowest possible power consumption.

  1. It enhances the initialization and deinitialization of the following drivers to enable achieving the lowest power consumption in STOP2 mode:

    • ltd_dsi display driver
    • backlight_pam
    • drv2625 driver
    • button driver
    • dma2d driver
    • optiga driver
  2. Adds new POWERCTL_SUSPEND syscall

  3. Introduces a new USE_USB feature utilized in the boardloader code.

  4. Adds a return value for the display_init() function, although it is not yet used anywhere.

@cepetr cepetr self-assigned this Dec 19, 2024
@cepetr cepetr added the T3W1 label Dec 19, 2024
Copy link

github-actions bot commented Dec 19, 2024

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@cepetr cepetr force-pushed the cepetr/powerctl-suspend branch from 289536e to 2e41fe6 Compare December 19, 2024 14:11
@cepetr cepetr requested a review from TychoVrahe December 19, 2024 14:31
@cepetr cepetr changed the title Suspend to lower power mode on T3W1 Suspend to low power mode on T3W1 Jan 6, 2025
@cepetr cepetr force-pushed the cepetr/powerctl-suspend branch from 2357c44 to 031f7ec Compare January 6, 2025 08:56
@cepetr cepetr marked this pull request as ready for review January 6, 2025 08:58
@cepetr cepetr requested a review from prusnak as a code owner January 6, 2025 08:58
@TychoVrahe TychoVrahe self-requested a review January 6, 2025 11:13
@cepetr cepetr force-pushed the cepetr/powerctl-suspend branch from 031f7ec to 220fd9e Compare January 6, 2025 11:28
Copy link
Contributor

@TychoVrahe TychoVrahe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM - pending known issues:

  • display RSOD is blue in boardloader on T3W1 A0
  • shutdown deinits display driver, making the RSOD just flash

core/embed/io/display/ltdc_dsi/display_driver.c Outdated Show resolved Hide resolved
@cepetr
Copy link
Contributor Author

cepetr commented Jan 8, 2025

LTGM - pending known issues:

  • display RSOD is blue in boardloader on T3W1 A0
  • shutdown deinits display driver, making the RSOD just flash

Please review these changes, which address all the mentioned issues:

f1439ad - resets peripherals in emergency mode (solves the blue RSOD screen)
342e47f - fixes linking problem in prodtest
4c0ee2e - a temporary workaround to prevent the screen from clearing after displaying RSOD

@cepetr cepetr requested a review from TychoVrahe January 8, 2025 17:01
@cepetr cepetr force-pushed the cepetr/powerctl-suspend branch 3 times, most recently from 1eff746 to 0714192 Compare January 13, 2025 16:14
@cepetr cepetr force-pushed the cepetr/powerctl-suspend branch from 0714192 to 0a8b807 Compare January 13, 2025 18:08
@cepetr cepetr merged commit b726e1e into main Jan 14, 2025
95 checks passed
@cepetr cepetr deleted the cepetr/powerctl-suspend branch January 14, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🤝 Needs QA
Development

Successfully merging this pull request may close these issues.

2 participants