Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): show ETH account info on all models #4471

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ibz
Copy link
Contributor

@ibz ibz commented Jan 6, 2025

This PR is a follow-up of #4175, to show the account info of ETH transactions on TS3 and model T, as it was previously only done on T3T1.

A compromise has been made versus the Figma designs (model T / TS3) - because the Frame's title is constant between pages, it has been set to "Information" on all pages.

Screenshots

image (1)
image (2)

Test command

trezorctl ethereum sign-tx -n "m/44'/60'/0'/0/0" -d 6162636465666768696a6b6c6d6e6f706162636465666768696a6b6c6d6e6f706162636465666768696a6b6c6d6e6f706162636465666768696a6b6c6d6e6f706162636465666768696a6b6c6d6e6f706162636465666768696a6b6c6d6e6f706162636465666768696a6b6c6d6e6f706162636465666768696a6b6c6d6e6f706162636465666768696a6b6c6d6e6f706162636465666768696a6b6c6d6e6f706162636465666768696a6b6c6d6e6f706162636465666768696a6b6c6d6e6f706162636465666768696a6b6c6d6e6f706162636465666768696a6b6c6d6e6f706162636465666768696a6b6c6d6e6f706162636465666768696a6b6c6d6e6f70 --max-gas-fee 100 --max-priority-fee 100 -e 2 -g 100 -G 100 -i 1 0x1d1c328764a41bda0492b66baa30c4a339ff85ef 11

@ibz ibz self-assigned this Jan 6, 2025
Copy link

github-actions bot commented Jan 6, 2025

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@ibz ibz marked this pull request as ready for review January 7, 2025 09:48
@ibz ibz requested review from matejcik and prusnak as code owners January 7, 2025 09:48
@ibz ibz requested review from obrusvit and removed request for prusnak and matejcik January 7, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 Needs review
Development

Successfully merging this pull request may close these issues.

1 participant