Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support per-layout translations entries #4495

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

romanz
Copy link
Contributor

@romanz romanz commented Jan 13, 2025

Following #4489.

Also, use layout names for translation font keys.

@romanz romanz self-assigned this Jan 13, 2025
Copy link

github-actions bot commented Jan 13, 2025

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@romanz romanz requested a review from obrusvit January 13, 2025 12:42
@romanz
Copy link
Contributor Author

romanz commented Jan 14, 2025

I will reorganize the commits above, in order to separate the text-modifying edits into a separate commit (which can be dropped - to avoid UI changes).

@romanz romanz force-pushed the romanz/translations branch from 8952a98 to 4148e87 Compare January 14, 2025 17:32
@romanz
Copy link
Contributor Author

romanz commented Jan 14, 2025

i.e., there is no diff between 8952a98 and 4148e87, just reorged the commits' content by the above force-push.

@romanz romanz marked this pull request as ready for review January 14, 2025 17:39
@romanz romanz changed the title WIP: Support per-layout translations entries Support per-layout translations entries Jan 14, 2025
@romanz romanz linked an issue Jan 14, 2025 that may be closed by this pull request
7 tasks
@romanz romanz added the translations Put this label on a PR to run tests in all languages label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translations Put this label on a PR to run tests in all languages
Projects
Status: 🔎 Needs review
Development

Successfully merging this pull request may close these issues.

1 participant