refactor(suite): rename menuIsOpen to isMenuOpen

trezor · Oct 1, 2024 · 5288cb9 · 5288cb9
1 parent 01c60f3
commit 5288cb9
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 12 deletions.
diff --git a/packages/components/src/components/form/Select/Select.stories.tsx b/packages/components/src/components/form/Select/Select.stories.tsx
@@ -37,7 +37,7 @@ export const Select: StoryObj<SelectProps> = {
         hasBottomPadding: true,
         size: 'large',
         minValueWidth: 'initial',
-        menuIsOpen: undefined,
+        isMenuOpen: undefined,
         useKeyPressScroll: undefined,
     },
     argTypes: {
@@ -80,7 +80,7 @@ export const Select: StoryObj<SelectProps> = {
         minValueWidth: {
             control: { type: 'text' },
         },
-        menuIsOpen: {
+        isMenuOpen: {
             control: {
                 type: 'boolean',
             },

diff --git a/packages/components/src/components/form/Select/Select.tsx b/packages/components/src/components/form/Select/Select.tsx
@@ -102,7 +102,7 @@ const createSelectStyle = (
 type WrapperProps = TransientProps<
     Pick<
         SelectProps,
-        'isClean' | 'isDisabled' | 'minValueWidth' | 'size' | 'menuIsOpen' | 'isSearchable'
+        'isClean' | 'isDisabled' | 'minValueWidth' | 'size' | 'isMenuOpen' | 'isSearchable'
     >
 > & {
     $isWithLabel: boolean;
@@ -250,7 +250,7 @@ const closeMenuOnScroll = (e: Event) =>
 
 export type Option = any;
 
-interface CommonProps extends Omit<ReactSelectProps<Option>, 'onChange'> {
+interface CommonProps extends Omit<ReactSelectProps<Option>, 'onChange' | 'menuIsOpen'> {
     isClean?: boolean;
     label?: ReactNode;
     size?: InputSize;
@@ -261,6 +261,7 @@ interface CommonProps extends Omit<ReactSelectProps<Option>, 'onChange'> {
     hasBottomPadding?: boolean;
     minValueWidth?: string; // TODO: should be probably removed
     inputState?: InputState;
+    isMenuOpen?: boolean;
     onChange?: (value: Option, ref?: SelectInstance<Option, boolean> | null) => void;
     'data-testid'?: string;
 }
@@ -283,7 +284,7 @@ export const Select = ({
     useKeyPressScroll,
     isSearchable = false,
     minValueWidth = 'initial',
-    menuIsOpen,
+    isMenuOpen,
     inputState,
     components,
     onChange,
@@ -305,14 +306,14 @@ export const Select = ({
             if (value) {
                 onChange?.(value, selectRef.current);
 
-                if (!menuIsOpen && action === 'select-option') {
+                if (!isMenuOpen && action === 'select-option') {
                     selectRef.current?.blur();
                 }
             }
 
             return null;
         },
-        [onChange, menuIsOpen],
+        [onChange, isMenuOpen],
     );
 
     /**
@@ -343,7 +344,7 @@ export const Select = ({
             $size={size}
             $minValueWidth={minValueWidth}
             $isDisabled={isDisabled}
-            $menuIsOpen={menuIsOpen}
+            $isMenuOpen={isMenuOpen}
             $isWithLabel={!!label}
             $isWithPlaceholder={!!placeholder}
             $hasBottomPadding={hasBottomPadding === true && bottomText === null}
@@ -359,7 +360,7 @@ export const Select = ({
                 styles={createSelectStyle(theme, elevation, isRenderedInModal)}
                 onChange={handleOnChange}
                 isSearchable={isSearchable}
-                menuIsOpen={menuIsOpen}
+                menuIsOpen={isMenuOpen}
                 isDisabled={isDisabled}
                 menuPlacement="auto"
                 placeholder={placeholder || ''}

diff --git a/packages/suite/src/components/suite/WordInput.tsx b/packages/suite/src/components/suite/WordInput.tsx
@@ -71,7 +71,7 @@ export const WordInput = memo(() => {
                 autoFocus
                 isSearchable
                 isClearable={false}
-                menuIsOpen
+                isMenuOpen
                 noOptionsMessage={({ inputValue }: { inputValue: string }) =>
                     translationString('TR_WORD_DOES_NOT_EXIST', { word: inputValue })
                 }

diff --git a/.../coinmarket/common/CoinmarketForm/CoinmarketFormInput/CoinmarketFormInputCryptoSelect.tsx b/.../coinmarket/common/CoinmarketForm/CoinmarketFormInput/CoinmarketFormInputCryptoSelect.tsx
@@ -129,7 +129,7 @@ export const CoinmarketFormInputCryptoSelect = <
                         }}
                         data-testid="@coinmarket/form/select-crypto"
                         isClearable={false}
-                        menuIsOpen={false}
+                        isMenuOpen={false}
                     />
                 )}
             />

diff --git a/...et/coinmarket/common/CoinmarketSelectedOffer/CoinmarketVerify/CoinmarketVerifyOptions.tsx b/...et/coinmarket/common/CoinmarketSelectedOffer/CoinmarketVerify/CoinmarketVerifyOptions.tsx
@@ -34,7 +34,7 @@ export const CoinmarketVerifyOptions = ({
             formatOptionLabel={option => (
                 <CoinmarketVerifyOptionsItem option={option} receiveNetwork={receiveNetwork} />
             )}
-            menuIsOpen={isMenuOpen}
+            isMenuOpen={isMenuOpen}
             isDisabled={selectAccountOptions.length === 1}
             placeholder={
                 <Translation