Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trading - when swapping receive accounts list is not organised by account number #14879

Open
bosomt opened this issue Oct 15, 2024 · 2 comments · May be fixed by #16265
Open

Trading - when swapping receive accounts list is not organised by account number #14879

bosomt opened this issue Oct 15, 2024 · 2 comments · May be fixed by #16265
Assignees
@enjojoy
Labels
bug Something isn't working as expected +Invity Related to Invity project

Comments

@bosomt
Copy link
Contributor

bosomt commented Oct 15, 2024

Describe the bug
See video or screenshot.
When swapping accounts list is not organised by account type or number.

Steps to reproduce:

  1. Perform swap to coin that have multiple used accounts in wallet
  2. Observe how accounts are sorted

Info:

  • Suite version: desktop 24.11.0 (9a86875)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuiteDev/24.11.0 Chrome/128.0.6613.162 Electron/32.1.2 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T3T1 2.8.4 regular (revision d71d9e9c343ad04a7f28d6b02f8d3f8945af30d6)
  • Transport: BridgeTransport 2.0.33

Screenshots:

image
Screen.Recording.2024-10-15.at.15.10.19.mov
@github-project-automation github-project-automation bot moved this to 🎯 To do in Issues Suite Oct 15, 2024
@tomasklim tomasklim added +Invity Related to Invity project bug Something isn't working as expected labels Oct 18, 2024
@tomasklim
Copy link
Member

Please order it first by account type first and then by order.
Image

E.g.
ETH 1 (default)
ETH 2 (default)
ETH 3 (default)
ETH 1 (ledger)
ETH 2 (ledger)
ETH1 (legacy)

@tomasklim
Copy link
Member

Related to #14881

@tomasklim tomasklim mentioned this issue Dec 29, 2024
Closed
@enjojoy enjojoy linked a pull request Jan 8, 2025 that will close this issue
Open
@tomasklim tomasklim moved this from 🎯 To do to 🏃‍♀️ In progress in Issues Suite Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enjojoy enjojoy

Labels
bug Something isn't working as expected +Invity Related to Invity project
Projects
Issues Suite
Status: 🏃‍♀️ In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sort receive accounts in swap section trezor/trezor-suite
3 participants
@bosomt @tomasklim @enjojoy