Sort receive accounts in swap section #16265
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enjojoy
changed the title
|
🚀 Expo preview is ready!
|
izmy
approved these changes
Jan 9, 2025
tomasklim
reviewed
Jan 14, 2025
Comment on lines
+18
to
+26
| const accountTypeOrder: Record<AccountType, number> = { | ||
| normal: 0, | ||
| ledger: 1, | ||
| legacy: 2, | ||
| imported: 3, | ||
| segwit: 4, | ||
| coinjoin: 5, | ||
| taproot: 6, | ||
| }; |
There was a problem hiding this comment.
I guess Bitcoiners will not be happy to have legacy accounts before segwit and taproot
I would expect something like:
- normal (BTC, ETH, SOL,...)
- taproot (BTC)
- segwit (BTC)
- coinjoin (BTC)
- ledger (ETH, SOL)
- legacy (BTC, ETH)
- imported (??? mobile)
Please someone confirm @hynek-jina @marekrjpolak
There was a problem hiding this comment.
I think we already have to have some ordering in Suite because it logically orders accounts in sidebar
There was a problem hiding this comment.
I would stick to that and reuse it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sort accounts by account type and account index
Related Issue
Resolve #14879
Screenshots: