chore(suite-native): cancel pin only if it was requested #13568
Merged
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add missing parenthesis
matejkriz
deleted the
chore/native/connect-device-screen-header-small-fixes
branch
|
QA NOK Info 24.8.0 5cd19fd |
|
I can't reproduce on 24.9.1, can you double check it @STew790, please? Screenrecorder-2024-09-19-17-20-01-390.mp4 |
|
QA OK Info |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add missing parenthesis and trigger connect cancel pin only if it was requested (ConnectDeviceScreenHeader is reused in multiple screens not related to PIN at all)
Notes for QA @STew790
Please test X (cancel button) on different connecting device flows (T1 with PIN, any other Trezor model than T1, locked device during app use...)