ci(connect): test model one #15387
Merged
ci(connect): test model one #15387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroz22
force-pushed
the
connect-test-model-one-ci
branch
from
66d9201 to
786fd2c
Compare
mroz22
force-pushed
the
connect-test-model-one-ci
branch
3 times, most recently
from
ce6f3b9 to
ef197f3
Compare
mroz22
force-pushed
the
connect-test-model-one-ci
branch
from
ef197f3 to
2acb91f
Compare
mroz22
added
the
no-project
mroz22
force-pushed
the
connect-test-model-one-ci
branch
from
2acb91f to
fb95237
Compare
mroz22
requested review from
szymonlesisz,
martykan,
marekrjpolak and
vdovhanych
as code owners
mroz22
commented
Jan 15, 2025
There was a problem hiding this comment.
fixed test setup in this file - it did not respect globally requested params (firmware version, model etc) for every test, so some of the test run with model T as default. Thats why so many changes
mroz22
commented
Jan 15, 2025
| TrezorConnect.removeAllListeners(); | ||
| const getAddressCall = getAddress(true); | ||
|
|
||
| // almost synchronous, TODO: core methodSynchronize race-condition in nodejs (works in web) | ||
| await new Promise(resolve => setTimeout(resolve, 1)); | ||
| // TODO: model T is happy with 1ms, model one needs more (1000 worked) | ||
| await new Promise(resolve => setTimeout(resolve, 1000)); |
There was a problem hiding this comment.
couple of races for model one detected
marekrjpolak
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add model one test to nightly ci routine
full run https://github.com/trezor/trezor-suite/actions/runs/12785034248/job/35639366768